Shift+Enter Bug

[ahackel]

Hi in the current qtranslate versions line breaks entered with shift+enter are converted into new paragraphs - the same break you would create when entering only enter. This is only true for the additional languages, when you type shift+enter in the default language everything is fine.

Steps to reproduce:
- go to edit post
- switch to a none-default language
- Enter a line of text, type shift+enter, enter another line of text
- Click publish
- switch to a different page
- go to edit post again
- switch to the language you used to enter the text
- now to shift+enter break has been converted into a enter-break

[hackeman]

Same problem here. Or similar I should say. In the default English language post it removes ALL line feeds, no matter if they were entered using regular Enter or Shift Enter, and in the non-default Language it INSERTS line feeds between all lines.

Even if I use HTML view and enter <br> code in the default language post these are deleted by qTranslate when post is saved. The only way to get an extra line feed where I want one now is to put a period (.) or any other character on that line.

The only way to get the translated page NOT to contain all those EXTRA line feeds inserted by qTranslate is to edit the post, remove all the line feeds, save the post and NEVER edit it again. Whenever I edit the post, qTranslates inserts the line feeds again.

Very annoying issue indeed.

[hackeman]

Btw, I've tried resetting qTranslate settings but didn't do any good.

[janim]

It seems that the bug is triggered by applying wpautop function twice to the content that is not in your default language.
Here's what I did to fix the bug:

Open qtranslate_javascript.php and replace the variable $q_config['js']['qtrans_assign'] with following:

Code: Select all

$q_config['js']['qtrans_assign'] = "

if ( typeof( switched ) == 'undefined' ) {
  switched = new Array();
  switched['".$q_config['default_language']."'] = 0;
}

qtrans_assign = function(id, text, lang) {   

  if ( typeof(switched[lang]) != 'undefined' ) {
    switched[lang] = 1;
  }
  else {
      switched[lang] = 0;
  }

  var inst = tinyMCE.get(id);
  var ta = document.getElementById(id);
  if(inst && ! inst.isHidden()) {
    if (switched[lang] == 1) {
      htm = switchEditors.wpautop(text);
    }
    else {
      htm = text;
    }

    inst.execCommand('mceSetContent', null, htm);
  } else {
    ta.value = text;
  }
}

";


Haven't tested this thoroughly yet so please do reply if you find any abnormal activities

[rufti66]

I have tryed to change the the variable $q_config['js']['qtrans_assign'] as discussed before but it didn't help. Still this bug is working, no change at all, which makes the otherwise so good working plugin useless, as with every small change inside one of the language the design of the secondary languages are lost. Anyone knows what to do? Thank you.

[oswaldson]

I have tryed to change the the variable $q_config['js']['qtrans_assign'] as discussed before but it didn't help.

janims workaround works like a charm! he only forgot to mention one little modification that is indispensable.

here is the working solution:

change in qtranslate_javascript.php:
replace the variable $q_config['js']['qtrans_assign'] with following (same as janim wrote):

Code: Select all

   $q_config['js']['qtrans_assign'] = "
      if ( typeof( switched ) == 'undefined' ) {
         switched = new Array();
         switched['".$q_config['default_language']."'] = 0;
      }

      qtrans_assign = function(id, text, lang) {

         if ( typeof(switched[lang]) != 'undefined' ) {
            switched[lang] = 1;
         }
         else {
            switched[lang] = 0;
         }

         var inst = tinyMCE.get(id);
         var ta = document.getElementById(id);
         if(inst && ! inst.isHidden()) {
            if (switched[lang] == 1) {
               htm = switchEditors.wpautop(text);
            }
            else {
               htm = text;
            }
            inst.execCommand('mceSetContent', null, htm);
         } else {
            ta.value = text;
         }
      }
      ";


additionally change the call of qtrans_assign in the last line of qtranslate_javascript.php.
replace qtrans_assign('qtrans_textarea_'+id,qtrans_use(lang,ta.value)); with:

Code: Select all

qtrans_assign('qtrans_textarea_'+id,qtrans_use(lang,ta.value),lang);

[jeroen1973]

I have noticed the same behaviour. It seems like a small change to the code. I hope it will be in version 2.5.14.

Regards, Jeroen

[robertn]

I had the same annoying problem, and your solution works great for me.
Thank you very much, janim and oswaldson, for providing the patches!
Without it, I would have to consider switching from qTranslate to WPML...
I hope that Qian will integrate these patches into qTranslate.

Kind Regards, Robert N.

[rufti66]

Thank you, now with the change to "qtrans_assign('qtrans_textarea_'+id,qtrans_use(lang,ta.value),lang);" it is working. Great!

Maybe this could be standard for any update or is there any reason why not?

[julien.fs]

Bump. Since we are the 13 January 2011 and this bug still exists in the last build. Really the kind of bug that make any serious users switch to other language plugins or CMS, since a simply correction that would normally take 5sec become a presentation fight of 10min.

To janim and oswaldson, THANKS A LOT! I've been banging my head on my keyboard because of this one.